Open
Conversation
…/berkeley-frodobots-lerobot-7k
github-actions
bot
added
documentation
Comment on lines
+344
to
+345
| "linear_velocity": float, | ||
| "angular_velocity": float, |
Collaborator
There was a problem hiding this comment.
Wouldn't these changes conflict with other workflows currently using the keyboard teleop (if any)? If there's no current workflow using this, then it's okay and feel free to ignore.
Member
Author
There was a problem hiding this comment.
KeyboardRoverTeleop was introduced specifically for the EarthRover and is not used by any other robot or workflow in the codebase. The renaming is safe.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
fix(earthrover): align dataset features with Hub dataset schema
Type / Scope
Summary / Motivation
The EarthRover robot implementation records different features than the frodobots/berkeley-frodobots-lerobot-7k Hub dataset. This PR aligns feature names and adds missing sensor data (IMU, magnetometer, wheel RPMs) from the SDK, making the recorded features a superset of the Hub dataset.
Related issues
What changed
How was this tested (or how to run locally)
Example:
Ran the relevant tests:
Reproduce with a quick example or CLI (if applicable):
Checklist (required before merge)
pre-commit run -a)pytest)Reviewer notes
filtered_position,relative_position,utm_position,filtered_heading,compass_heading,action_mbra,action_original).